• Joined on 2025-04-03
dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

delete commented code

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

the lower function has export default function but this one just has function, why?

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

this has routes, the other doesn't, why?

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

all imports should at least be in some sort of alphabetical order. idk how best to do that in react tho

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

what is a .jsx file anyway?

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

this function is just for debugging, probably should not be in master

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

damn, more css

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

probably wana do prefers-color-scheme: system (idr if that is what it is tho)

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

why is this file in here?

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

why are dev dependencies different from prod dependencies?

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

is it react standard for the file to be uppercase App.css? having an uppercase letter in file is weird and i would only do it if it was required by react

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

what actually is vite, why is it required

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

are these better as ids or classes?

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

i feel like a lot of these names are ambiguous. like next steps what, docs what? I imagine we will have a documentation page.

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

this implies we will have multiple link styles... i would take a look at a lot of your nested css and see if there are things that could be put at the global level, why do we need a special link here, it is just going to lead to an inconsistent UI

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

damn okay. we have a lot of css in multiple files. you need to probably really create a single css file and inherit it in most cases, with only minor tweaks for each page.

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

why is this not in app.jsx then? im not saying to do that, but this is inconsistent.

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

ai slop comment

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

you can probably abstract the map html into its own component, because it is going to have to be reused again

dominic commented on pull request dominic/localist#27 2026-06-21 16:58:51 -04:00
buidlingreactUI

organize imports better